[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[EP-tech] Re: a lot of warnings concerning uninitialized value



...or at the top of the function:

	return undef unless defined $row->[0];

I think this is slightly better as it defined an exception that's handled ahead of the function doing its thing.  If you don't like the unless operator:

	return undef if !defined $row->[0];


--
Adam Field
Business Relationship Manager and Community Lead
EPrints Services
+44 (0)23 8059 8814





On 10 Nov 2015, at 14:49, Field A.N. wrote:

> Hi Thomas
> 
> 	Yes, it's probably be better as something like:
> 
> 		utf8::decode( $row->[0] ) if defined $row->[0];
> 
> 	Perhaps submit an issue on github?
> 
> --
> Adam Field
> Business Relationship Manager and Community Lead
> EPrints Services
> +44 (0)23 8059 8814
> 
> 
> 
> 
> 
> On 10 Nov 2015, at 09:38, Thomas Lauke wrote:
> 
>> Hi Adam,
>> 
>>> Does the admin user have a name set?  That might be the issue.
>> sure, that influences the warnings (specifying the required name results in 4 warnings less) ...
>> but imho the initialization in /usr/share/eprints3/bin/../perl_lib/EPrints/MetaField/Id.pm should be implemented as well!?
>> Then some more warnings for other executions would disappear also :-)
>> 
>> Hand
>> Thomas
>> *** Options: http://mailman.ecs.soton.ac.uk/mailman/listinfo/eprints-tech
>> *** Archive: http://www.eprints.org/tech.php/
>> *** EPrints community wiki: http://wiki.eprints.org/
>> *** EPrints developers Forum: http://forum.eprints.org/
> 
> 
> *** Options: http://mailman.ecs.soton.ac.uk/mailman/listinfo/eprints-tech
> *** Archive: http://www.eprints.org/tech.php/
> *** EPrints community wiki: http://wiki.eprints.org/
> *** EPrints developers Forum: http://forum.eprints.org/