[EP-tech] 3.3.16 Unit Tests

[Matthew.Brady at usq.edu.au (Matthew Brady)]

CAUTION: This e-mail originated outside the University of Southampton.
Hi All,

Building up new system, with updated OS, packages etc, still running 3.3.16 codebase, and running unit tests to make sure it's all playing nicely...

I have a warning coming in via tests/81_workflow.pl

Use of uninitialized value in string eq at /opt/eprints3/perl_lib/EPrints/Plugin/InputForm/Component/Field/AjaxSubject.pm line 148, <DATA> line 960.

Just wondering if it's a code mishap in the .pm, or if it's a data issue for the testing....

The '$self->{search}' variable is set to undef  ~ 20 lines prior...
Then has 2 chances to be defined, then evaluated...

if( $self->{search} eq "" )
{
    delete $self->{search};
}

If I add 'if defined' to the evaluation, the warning no longer occurs...
if( defined $self->{search} && $self->{search} eq "" )
{
    delete $self->{search};
}

But is it a code issue, or is the test legitimately finding something wrong with the data its using as part of the testing process??


Cheers

Matt.
__________________________________________________________________
This email (including any attached files) is confidential and is
for the intended recipient(s) only. If you received this email by
mistake, please, as a courtesy, tell the sender, then delete this
email.
The views and opinions are the originator's and do not necessarily
reflect those of the University of Southern Queensland. Although
all reasonable precautions were taken to ensure that this email
contained no viruses at the time it was sent we accept no
liability for any losses arising from its receipt.
The University of Southern Queensland is a registered provider
of education with the Australian Government.
(CRICOS Institution Code QLD 00244B / NSW 02225M, TEQSA PRV12081)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mailman.ecs.soton.ac.uk/pipermail/eprints-tech/attachments/20230328/fe2dd707/attachment.html