[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[EP-tech] Document field title/help-text using a phrase in workflow

CAUTION: This e-mail originated outside the University of Southampton.
Hi,
I've just observed some curious behaviour in EPrints 3.3.16, and wondered whether it also impacts 3.4.x (don't have a test system at hand to try it out at the moment).

In the default eprint workflow, in the 'files' stage, if you define a document field title or help-text using a phrase, it doesn't get rendered for the second (or more) document.
To re-create:

  1.  upload two documents to an eprint.
  2.  In the workflow, change the default field spec:
     *   <field ref="license"/>
  3.  to use a phrase for the help-text:
     *   <field ref="license">
     *     <help><epc:phrase ref="archive_name"/></help>
     *   </field>

  1.  re-load the 'Upload' workflow - the 'show help' icon is not rendered for the licence field for the second document (see screenshot below)

If you embed text directly into the workflow (bad practice!)
  <help>This is some help text</help>
it appears to work OK.

I think the issue is with the caching of the html_xhtml field property in EPrint::MetaField.

I've traced the help-text back to:
https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Feprints%2Feprints%2Fblob%2Fmaster%2Fperl_lib%2FEPrints%2FPlugin%2FInputForm%2FComponent.pm%23L496-L503&amp;data=05%7C01%7Ceprints-tech%40ecs.soton.ac.uk%7Cf4a00215c74d4c53126f08daa5eceabb%7C4a5378f929f44d3ebe89669d03ada9d8%7C0%7C0%7C638004734209753098%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=j3XqYRy0XTOGe7Tx%2BqFEbjCeJhP%2FKeSqLcQ4xkdzwTg%3D&amp;reserved=0
 (v3.4 equivalent: https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Feprints%2Feprints3.4%2Fblob%2Fmaster%2Fperl_lib%2FEPrints%2FPlugin%2FInputForm%2FComponent.pm%23L450-L457&amp;data=05%7C01%7Ceprints-tech%40ecs.soton.ac.uk%7Cf4a00215c74d4c53126f08daa5eceabb%7C4a5378f929f44d3ebe89669d03ada9d8%7C0%7C0%7C638004734209753098%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=jh4hTmfapyVFshMMYpJGtfu8QNoSEnQaRuMoupMIy9Q%3D&amp;reserved=0 )
and I suspect the issue may lie with this 'clone':
https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Feprints%2Feprints%2Fblob%2Fmaster%2Fperl_lib%2FEPrints%2FPlugin%2FInputForm%2FComponent.pm%23L527&amp;data=05%7C01%7Ceprints-tech%40ecs.soton.ac.uk%7Cf4a00215c74d4c53126f08daa5eceabb%7C4a5378f929f44d3ebe89669d03ada9d8%7C0%7C0%7C638004734209753098%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=Wk62cm7%2BD%2B%2FNF8KzrVZM2B9k1j0TqX%2FekiRSQGG2eSI%3D&amp;reserved=0
(v3.4 equivalent: https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Feprints%2Feprints3.4%2Fblob%2Fmaster%2Fperl_lib%2FEPrints%2FPlugin%2FInputForm%2FComponent.pm%23L481&amp;data=05%7C01%7Ceprints-tech%40ecs.soton.ac.uk%7Cf4a00215c74d4c53126f08daa5eceabb%7C4a5378f929f44d3ebe89669d03ada9d8%7C0%7C0%7C638004734209908875%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=qAvI6TIXdX%2FKKYJOANElOyXQQCJ7oNvasavyL0%2BY9cM%3D&amp;reserved=0 )

Cheers,
John


[cid:cfb0e01c-2c47-49c4-adb3-3bc235175a04]

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mailman.ecs.soton.ac.uk/pipermail/eprints-tech/attachments/20221004/7eddba7a/attachment-0001.html 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image.png
Type: image/png
Size: 78722 bytes
Desc: image.png
Url : http://mailman.ecs.soton.ac.uk/pipermail/eprints-tech/attachments/20221004/7eddba7a/attachment-0001.png