[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[EP-tech] <epc:list> not implemented for 3.4.x

CAUTION: This e-mail originated outside the University of Southampton.

Hi David,

Thank you, I appreciate it and will look forward to having this
functionality hopefully in 3.4.4.

In the meantime, it took a little while but I found a way to port it in
temporarily from v3.3. In case this is useful for anyone else, in
archives/[name]/cfg/plugins/EPrints/Plugin/MyEPC.pm (say):

```
package EPrints::Plugin::MyEPC;
use strict;
our @ISA = qw/ EPrints::Plugin /;

# Mostly the same as EPrints::XML::EPC::process

sub process
{
    ...
    if ( $name =~
    m/^(if|comment|choose|print|debug|phrase|pin|foreach|set|list)$/ )
    {
        my $fn = "EPrints::XML::EPC::_process_$name";
        ...
    }
    ...

    if ( $node->hasChildNodes )
    {
        $collapsed->appendChild(
            EPrints::XML::EPC::process_child_nodes( $node, %params )
        );
    }
    return $collapsed;
}

package EPrints::XML::EPC;

BEGIN
{
    delete $EPrints::XML::EPC::{process};
    *EPrints::XML::EPC::process = \&EPrints::Plugin::MyEPC::process;
}

# From
https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Feprints%2Feprints%2Fblob%2F3.3%2Fperl_lib%2FEPrints%2FXML%2FEPC.pm&amp;data=04%7C01%7Ceprints-tech%40ecs.soton.ac.uk%7Ce05967690a034919e56e08da06ae0e96%7C4a5378f929f44d3ebe89669d03ada9d8%7C0%7C0%7C637829641872912999%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=uwLn26%2FNZwCdZbhv22wmcD0COXTHfh%2FZUJOCURheWuI%3D&amp;reserved=0

sub _process_list
{...}
```

Probably could be done more elegantly but it's working so far as a
stopgap.

Many thanks,
Alex.


On Tue, 2022-03-15 at 15:43 +0000, David R Newman wrote:
> Hi Alex,
>
> Those must have never got added to 3.4.  I can see that I edited the
> wiki for this back in April 2019.  This would have been shortly after
> 3.4.1 was released.  At the time we were still maintaining an
> internal Subversion and an external Git master branch for the
> codebase, which was a bit of a nightmare to maintain as you can
> probably imagine.  Before 3.4.2, I rationalised this so there is only
> the Git master branch available at:
>
> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Feprints%2Feprints3.4&amp;data=04%7C01%7Ceprints-tech%40ecs.soton.ac.uk%7Ce05967690a034919e56e08da06ae0e96%7C4a5378f929f44d3ebe89669d03ada9d8%7C0%7C0%7C637829641872912999%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=MfdYw5F3nF9bIralANot5mZtEnUP%2FMo3CN9eXTcxtIY%3D&amp;reserved=0
>
> I suspect what may have happened was that these additional EPC
> functions feel through the cracks during the rationalisation
> process.  I will see if I can dig a little deeper and find out what
> went wrong.  I have also added a GitHub issue for these to be added
> in time for 3.4.4:
> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Feprints%2Feprints3.4%2Fissues%2F202&amp;data=04%7C01%7Ceprints-tech%40ecs.soton.ac.uk%7Ce05967690a034919e56e08da06ae0e96%7C4a5378f929f44d3ebe89669d03ada9d8%7C0%7C0%7C637829641872912999%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=3UUWLPcCqeIS5k0nkmcTfVKBF%2BN760PLTJekx3gWfi0%3D&amp;reserved=0
>
> I am really not sure when 3.4.4 will be released as the list of
> issues still open and associated with that milestone is still rather
> long and I seem to have very little time to work on them. The end of
> April 2022 may be overly optimistic.  Especially, as I need to write
> a whole suite of user acceptance tests for CI, before I even get to
> the testing phase of a 3.4.4 release.
>
> Regards
>
> David Newman

--
Alex Ball (he/him)
Research Data Librarian (Systems)
University of Bath, Bath BA2 7AY, UK
https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.bath.ac.uk%2Flibrary%2F&amp;data=04%7C01%7Ceprints-tech%40ecs.soton.ac.uk%7Ce05967690a034919e56e08da06ae0e96%7C4a5378f929f44d3ebe89669d03ada9d8%7C0%7C0%7C637829641872912999%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=is%2FYu0aRcxjntcwTg72uE8Nx0NDbZ55LEPsNYAy0bSU%3D&amp;reserved=0