[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[EP-tech] ORCID plugin on 3.3.16



Hi Matt,

I think if you have upgraded a Bazaar plugin and a file for this plugin 
was modified since it was installed.? The new version should still be 
installed but with the suffix .epmnew.? So if you upgrade to version 1.7 
and then can find both the following files (where EPRINTS_PATH may be 
/opt/eprints3 or /usr/share/eprints):

EPRINTS_PATH/lib/plugins/EPrints/Plugin/Screen/ImportFromOrcid.pm

EPRINTS_PATH/lib/plugins/EPrints/Plugin/Screen/ImportFromOrcid.pm.epmnew

then you will need to merge these the changes from 
ImportFromOrcid.pm.epmnew into ImportFromOrcid.pm.? It is difficult to 
advise how you might do this without knowing what local modifications 
you may have made.

Regards

David Newman

On 16/06/2022 1:12 am, Matthew Brady wrote:
> *CAUTION:* This e-mail originated outside the University of Southampton.
>
> Hi David,
>
> Thanks for the prompt reply. I wasn?t expecting anything due to TZ 
> differences ?
>
> Its likely the version we are using? it?s been in place for a couple 
> of years, and ?slightly? modified to suit our Author subsystem 
> implementation?
>
> I had gone wandering through the code, but couldn?t see for looking?
>
> Cheers,
>
> Matt.
>
> *From:*eprints-tech-bounces at ecs.soton.ac.uk 
> <eprints-tech-bounces at ecs.soton.ac.uk> *On Behalf Of *David R Newman 
> via Eprints-tech
> *Sent:* Thursday, 16 June 2022 10:00 AM
> *To:* eprints-tech at ecs.soton.ac.uk; Matthew Brady 
> <Matthew.Brady at usq.edu.au>
> *Subject:* Re: [EP-tech] ORCID plugin on 3.3.16
>
> Hi Matt,
>
> I have just reviewed the code and it looks like in older versions of 
> the ORCID Support Advance (version 1.5 and earlier) it only imports 
> creators who have an ORCID ID set for them in the "work" item in ORCID 
> imported from the importing user's set of works.? I am not sure what 
> the logic was behind this choice, as I was not involved in the 
> development of these plugins.? The code where these logic is applied 
> can be found in lib/plugins/EPrints/Plugin/Screen/ImportFromOrcid.pm. 
> The line you are looking for is:
>
> if( defined( $contributor->{"contributor-orcid"} ) )
>
> I have taken a quick look at the GitHub issues for this Git repository 
> and found this particular issue:
>
> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Feprints%2Forcid_support_advance%2Fissues%2F27&amp;data=05%7C01%7Ceprints-tech%40ecs.soton.ac.uk%7C42aa406f98594dc2be1708da4f2e0efc%7C4a5378f929f44d3ebe89669d03ada9d8%7C0%7C0%7C637909356478904630%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=i4dIsKDqdfdHtH8TAxbqzC9BeRfyeK2gi7uVOPK4RjY%3D&amp;reserved=0 
> <https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Feprints%2Forcid_support_advance%2Fissues%2F27&amp;data=05%7C01%7Ceprints-tech%40ecs.soton.ac.uk%7C42aa406f98594dc2be1708da4f2e0efc%7C4a5378f929f44d3ebe89669d03ada9d8%7C0%7C0%7C637909356478904630%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=i4dIsKDqdfdHtH8TAxbqzC9BeRfyeK2gi7uVOPK4RjY%3D&amp;reserved=0>
>
> The patch this discusses looks to have been merged into the master 
> branch in February 2020.? The latest version (1.7) of the ORCID 
> Support Advance plugin (https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fbazaar.eprints.org%2F1155%2F&amp;data=05%7C01%7Ceprints-tech%40ecs.soton.ac.uk%7C42aa406f98594dc2be1708da4f2e0efc%7C4a5378f929f44d3ebe89669d03ada9d8%7C0%7C0%7C637909356478904630%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=4hOb%2BJuhgcwa5kTkE7aLThnX6FZ67ECAJZgD%2BiUlKoE%3D&amp;reserved=0 
> <https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fbazaar.eprints.org%2F1155%2F&amp;data=05%7C01%7Ceprints-tech%40ecs.soton.ac.uk%7C42aa406f98594dc2be1708da4f2e0efc%7C4a5378f929f44d3ebe89669d03ada9d8%7C0%7C0%7C637909356478904630%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=4hOb%2BJuhgcwa5kTkE7aLThnX6FZ67ECAJZgD%2BiUlKoE%3D&amp;reserved=0>) 
> looks to be from January 2021 and has this patch, as does the version 
> from February 2020 (1.5.1, https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fbazaar.eprints.org%2F1138%2F&amp;data=05%7C01%7Ceprints-tech%40ecs.soton.ac.uk%7C42aa406f98594dc2be1708da4f2e0efc%7C4a5378f929f44d3ebe89669d03ada9d8%7C0%7C0%7C637909356478904630%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=bZGDZPXBD09%2F1hoEkVvTf8OBRXqzPlNBTILtGir1DjQ%3D&amp;reserved=0 
> <https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fbazaar.eprints.org%2F1138%2F&amp;data=05%7C01%7Ceprints-tech%40ecs.soton.ac.uk%7C42aa406f98594dc2be1708da4f2e0efc%7C4a5378f929f44d3ebe89669d03ada9d8%7C0%7C0%7C637909356478904630%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=bZGDZPXBD09%2F1hoEkVvTf8OBRXqzPlNBTILtGir1DjQ%3D&amp;reserved=0>).? 
> If you have a version of ORCID Support Advance earlier than 1.5.1, 
> that would explain why this is not working.? Also, sometimes if you 
> modify files for Bazaar plugins and then upgrade the plugin, the 
> modified files will not necessarily be updated.? So even if you are 
> running one of these two recent versions, it is worth checking to see 
> if ImportFromOrcid.pm contains the fix from this patch.? Like above, 
> look for the line:
>
> if( defined( $contributor->{"contributor-orcid"} ) )
>
> and check that there is a block after this that deals with just adding 
> the creators name, even if there is no ORCID ID sent through from 
> ORCID for a contributor.
>
> Regards
>
> David Newman
>
> On 16/06/2022 12:15 am, Matthew Brady via Eprints-tech wrote:
>
>     *CAUTION:*This e-mail originated outside the University of
>     Southampton.
>
>     Hi All,
>
>     We have the ORCID plugins (ORCID Support and ORCID Support
>     Advance) up and running,
>
>     Linking users to ORCID, obtaining their ID?s and exporting records
>     out to ORCID all working, however?
>
>     When importing from ORCID into ePrints, the metadata comes in as
>     expected, but the process only creates a single eprint_creator
>     record (which links to the ORCID user performing the import), even
>     though there may be multiple authors in the ORCID record, and the
>     user may/may not be the first author in the publication.
>
>     Has anyone seen this behaviour?
>
>     Thanks for any help / advice.
>
>     Matt.
>
>     __________________________________________________________________
>
>     This email (including any attached files) is confidential and is
>
>     for the intended recipient(s) only. If you received this email by
>
>     mistake, please, as a courtesy, tell the sender, then delete this
>
>     email.
>
>     The views and opinions are the originator's and do not necessarily
>
>     reflect those of the University of Southern Queensland. Although
>
>     all reasonable precautions were taken to ensure that this email
>
>     contained no viruses at the time it was sent we accept no
>
>     liability for any losses arising from its receipt.
>
>     The University of Southern Queensland is a registered provider
>
>     of education with the Australian Government.
>
>     (CRICOS Institution Code QLD 00244B / NSW 02225M, TEQSA PRV12081)
>
>
>
>     *** Options:http://mailman.ecs.soton.ac.uk/mailman/listinfo/eprints-tech
>
>     *** Archive:https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.eprints.org%2Ftech.php%2F&amp;data=05%7C01%7Ceprints-tech%40ecs.soton.ac.uk%7C42aa406f98594dc2be1708da4f2e0efc%7C4a5378f929f44d3ebe89669d03ada9d8%7C0%7C0%7C637909356478904630%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=4CBnBf4DLtIJ883DSWGyIpm%2FtLleuaOzoeA0uGfZC9o%3D&amp;reserved=0  <https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.eprints.org%2Ftech.php%2F&amp;data=05%7C01%7Ceprints-tech%40ecs.soton.ac.uk%7C42aa406f98594dc2be1708da4f2e0efc%7C4a5378f929f44d3ebe89669d03ada9d8%7C0%7C0%7C637909356478904630%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=4CBnBf4DLtIJ883DSWGyIpm%2FtLleuaOzoeA0uGfZC9o%3D&amp;reserved=0>
>
>     *** EPrints community wiki:https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwiki.eprints.org%2F&amp;data=05%7C01%7Ceprints-tech%40ecs.soton.ac.uk%7C42aa406f98594dc2be1708da4f2e0efc%7C4a5378f929f44d3ebe89669d03ada9d8%7C0%7C0%7C637909356478904630%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=gHD7mzi%2BHSBrYHJRGrAGhxAsUEunS4Vj4G%2Bt%2Fs4mfmA%3D&amp;reserved=0  <https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwiki.eprints.org%2F&amp;data=05%7C01%7Ceprints-tech%40ecs.soton.ac.uk%7C42aa406f98594dc2be1708da4f2e0efc%7C4a5378f929f44d3ebe89669d03ada9d8%7C0%7C0%7C637909356478904630%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=gHD7mzi%2BHSBrYHJRGrAGhxAsUEunS4Vj4G%2Bt%2Fs4mfmA%3D&amp;reserved=0>
>
> __________________________________________________________________
> This email (including any attached files) is confidential and is
> for the intended recipient(s) only. If you received this email by
> mistake, please, as a courtesy, tell the sender, then delete this
> email.
> The views and opinions are the originator's and do not necessarily
> reflect those of the University of Southern Queensland. Although
> all reasonable precautions were taken to ensure that this email
> contained no viruses at the time it was sent we accept no
> liability for any losses arising from its receipt.
> The University of Southern Queensland is a registered provider
> of education with the Australian Government.
> (CRICOS Institution Code QLD 00244B / NSW 02225M, TEQSA PRV12081)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mailman.ecs.soton.ac.uk/pipermail/eprints-tech/attachments/20220616/d352335d/attachment-0001.html