[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[EP-tech] Debug Creator browse view generation

OK, I think the code is confusingly written.  Here?s my take:

if ($value =~ /^[+-]?\d+$/ ) ? if $value is an integer number of some (possibly with a + or ? at the beginning

if (scalar @{$session->get_database->search_sql_ldap($value)}){ If whatever array the function returns has at least one element

my @check = @{$session->get_database->search_sql_ldap($value)}; Call the function again (!) to get the array

if(defined($check[0][0]) && defined($check[0][1])) If the first element of the array is an array that has two elements

my $string_build = $check[0][0] . ", " . $check[0][1]; //concatenate the two element

return $session->make_text( $string_build ); // turn it into a DOM element

Aside from calling a function that almost certainly does a database query twice (rewrite is probably advisable), there?s nothing in this code that would cause an issue.  My guess is that search_sql_ldap is throwing an exception.  You can go about this two ways:

1)       Quick and easy:

my @check;
                @check = @{$session->get_database->search_sql_ldap($value)};
if (
$@ //an error occured
                || ! (scalar @check) //empty array returned
                || ! $check[0][0] // no given name
                || ! $check[0][1] // no family name
                return $session->make_text($value);
my $string_build = $check[0][0] . ", " . $check[0][1];
return $session->make_text( $string_build );

2)       The correct approach

The problem with (1) approach is that it doesn?t address the underlying issue ? search_sql_ldap is throwing an exception.  The correct approach is to figure out why.  Do you have any error output or lines in the error log associated with this failure?

[cid:image001.png at 01D23FFD.E89880B0]<http://www.jisc.ac.uk/>

Adam Field
SHERPA services analyst developer

From: <eprints-tech-bounces at ecs.soton.ac.uk> on behalf of Andrew Beeken <anbeeken at lincoln.ac.uk>
Reply-To: "eprints-tech at ecs.soton.ac.uk" <eprints-tech at ecs.soton.ac.uk>
Date: Wednesday, 16 November 2016 10:59
To: "eprints-tech at ecs.soton.ac.uk" <eprints-tech at ecs.soton.ac.uk>
Subject: Re: [EP-tech] Debug Creator browse view generation

Thanks both!

It looks like the issue here is a data issue. A function in Authorid.pm has had some code added to it which checks against a database table for users which are no longer at the institution, however it doesn?t seem to be able to cope with a user that isn?t present in that table. The function is:

sub get_value_label
                my( $self, $session, $value ) = @_;

                my $user = EPrints::DataObj::User->new( $session, $value );

                #Checks the normal process and returns the user if found.
                if( defined $user )
                                return $session->make_text( EPrints::Utils::make_name_string( $self->_get_name( $session, $user ) ) );

                #If not returned with normal user checks value is a valid number and trys to pull the user from the ldap_user table instead
                if ($value =~ /^[+-]?\d+$/ )
                                if (scalar @{$session->get_database->search_sql_ldap($value)}){ << THIS IS THE LINE THAT?S GIVING ME GRIEF!
                                    my @check = @{$session->get_database->search_sql_ldap($value)};

                                    if(defined($check[0][0]) && defined($check[0][1]))
                                                my $string_build = $check[0][0] . ", " . $check[0][1];
                                                return $session->make_text( $string_build );

                #Otherwise just simply output the value
                return $session->make_text( $value );
                #return $session->make_text( "me" );

?and I?ve marked the problematic line of code. When it encounters an empty string instead of a scalar, the view generator goes?


?and falls over. Giving us no generated views. And a 500 error. Which is nice.

So, I think the answer is to handle that empty string and let the function carry on to the fallback of returning the value, however my knowledge of perl is less than functional at best and I really don?t want to do any more irrevocable damage. Any thoughts would be welcome!


From: eprints-tech-bounces at ecs.soton.ac.uk [mailto:eprints-tech-bounces at ecs.soton.ac.uk] On Behalf Of John Salter
Sent: 15 November 2016 14:43
To: eprints-tech at ecs.soton.ac.uk
Subject: Re: [EP-tech] Debug Creator browse view generation

> bin/generate_views ARCHIVEID --view viewid --verbose

(You can do ?--verbose --verbose? if you really need to!).

Depending on where your issue lies, you might want to use one of these options too:
--generate menus
--generate lists

Which will be a bit quicker than a full run.


From: eprints-tech-bounces at ecs.soton.ac.uk<mailto:eprints-tech-bounces at ecs.soton.ac.uk> [mailto:eprints-tech-bounces at ecs.soton.ac.uk] On Behalf Of Andrew Beeken
Sent: 15 November 2016 14:26
To: eprints-tech at ecs.soton.ac.uk<mailto:eprints-tech at ecs.soton.ac.uk>
Subject: [EP-tech] Debug Creator browse view generation

Hello all!

So, back to that old chestnut of errors throwing in our EPrints installation (yay!) I?ve had to do some tweaks to make it read our LDAP table. Now I?m getting errors on the creator browse generation! I think I?ve figured out where the problems are occurring however I don?t know if it?s a code issue or a data issue. Is there a way of running the view generator from the command line with ?verbose so that I can see what it?s trying to do and figure out where the error is occurring?


The University of Lincoln, located in the heart of the city of Lincoln, has established an international reputation based on high student satisfaction, excellent graduate employment and world-class research.

The information in this e-mail and any attachments may be confidential. If you have received this email in error please notify the sender immediately and remove it from your system. Do not disclose the contents to another person or take copies.

Email is not secure and may contain viruses. The University of Lincoln makes every effort to ensure email is sent without viruses, but cannot guarantee this and recommends recipients take appropriate precautions.

The University may monitor email traffic data and content in accordance with its policies and English law. Further information can be found at: http://www.lincoln.ac.uk/legal.

Jisc is a registered charity (number 1149740) and a company limited by guarantee which is registered in England under Company No. 5747339, VAT No. GB 197 0632 86. Jisc?s registered office is: One Castlepark, Tower Hill, Bristol, BS2 0JA. T 0203 697 5800.

Jisc Services Limited is a wholly owned Jisc subsidiary and a company limited by guarantee which is registered in England under company number 2881024, VAT number GB 197 0632 86. The registered office is: One Castle Park, Tower Hill, Bristol BS2 0JA. T 0203 697 5800.  
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mailman.ecs.soton.ac.uk/pipermail/eprints-tech/attachments/20161116/26067d30/attachment-0001.html 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image001.png
Type: image/png
Size: 1264 bytes
Desc: image001.png
Url : http://mailman.ecs.soton.ac.uk/pipermail/eprints-tech/attachments/20161116/26067d30/attachment-0001.png