[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[EP-tech] Issue with searchfield labels and checkbox ids



Hi Cristian,
Thanks for taking a look at these.

I've been doing some accessibility checking (using http://wave.webaim.org/) which highlighted the missing labels as issues.
In trying to fix the main missing labels, I discovered the repeated ids - which will take a bit more fixing.

I'll submit a patch when I've got something sensible - the guide here: http://webaim.org/techniques/forms/controls#checkbox suggests wrapping the multi-checkbox in a fieldset - which will require some additional styling.

Cheers,
John

-----Original Message-----
From: eprints-tech-bounces at ecs.soton.ac.uk [mailto:eprints-tech-bounces at ecs.soton.ac.uk] On Behalf Of Centro de Documentaci?n
Sent: 25 August 2016 14:43
To: eprints-tech at ecs.soton.ac.uk
Subject: Re: [EP-tech] Issue with searchfield labels and checkbox ids

On Wed, Aug 24, 2016 at 6:27 AM, John Salter <J.Salter at leeds.ac.uk> wrote:
> Hi,
>
> Can someone running v3.3.15 check a couple of things for me:
>
> 1.       On the advanced search page, do the search input fields have a
> corresponding <label> element?

Hi John,

No, only checkboxes have a <label> element.

>
> 2.       If you have a multi-checkbox search input, do all the checkboxes
> have the same id attribute?

Yes,

<div><label><input name="type" id="type" value="article"
class="ep_form_checkbox" type="checkbox"> Art?culo</label></div>
                        <div><label><input name="type" id="type"
value="book_section" class="ep_form_checkbox" type="checkbox"> Parte
de Libro</label></div>
                        <div><label><input name="type" id="type"
value="monograph" class="ep_form_checkbox" type="checkbox">
Monograf?a</label></div>
                        <div><label><input name="type" id="type"
value="conference_item" class="ep_form_checkbox" type="checkbox">
Documento de Conferencia</label></div>

/////////////////////////////////////////////

 <div><label><input name="ispublished" id="ispublished" value="pub"
class="ep_form_checkbox" type="checkbox"> Publicado</label></div>
                        <div><label><input name="ispublished"
id="ispublished" value="inpress" class="ep_form_checkbox"
type="checkbox"> En Prensa</label></div>
                        <div><label><input name="ispublished"
id="ispublished" value="submitted" class="ep_form_checkbox"
type="checkbox"> En Evaluaci?n</label></div>
                        <div><label><input name="ispublished"
id="ispublished" value="unpub" class="ep_form_checkbox"
type="checkbox"> In?dito</label></div>

/////////////////////////////////////////////

<div><label><input name="documents.format" id="documents.format"
value="text/html" class="ep_form_checkbox" type="checkbox">
HTML</label></div>
                        <div><label><input name="documents.format"
id="documents.format" value="application/pdf" class="ep_form_checkbox"
type="checkbox"> PDF</label></div>
                        <div><label><input name="documents.format"
id="documents.format" value="application/postscript"
class="ep_form_checkbox" type="checkbox"> Postscript</label></div>
                        <div><label><input name="documents.format"
id="documents.format" value="text/plain" class="ep_form_checkbox"
type="checkbox"> Texto Plano</label></div>
                        <div><label><input name="documents.format"
id="documents.format" value="application/rtf" class="ep_form_checkbox"
type="checkbox"> Rich Text (RTF)</label></div>


Regards,

Cristian



>
>
>
> Cheers,
>
> John
>
>
>
>
> *** Options: http://mailman.ecs.soton.ac.uk/mailman/listinfo/eprints-tech
> *** Archive: http://www.eprints.org/tech.php/
> *** EPrints community wiki: http://wiki.eprints.org/
> *** EPrints developers Forum: http://forum.eprints.org/
>

*** Options: http://mailman.ecs.soton.ac.uk/mailman/listinfo/eprints-tech
*** Archive: http://www.eprints.org/tech.php/
*** EPrints community wiki: http://wiki.eprints.org/
*** EPrints developers Forum: http://forum.eprints.org/