EPrints Technical Mailing List Archive

Message: #09468

< Previous (by date) | Next (by date) > | < Previous (in thread) | Next (in thread) > | Messages - Most Recent First | Threads - Most Recent First

Re: [EP-tech] ORCID Plugin Subroutine run_people_with_orcids redefined

CAUTION: This e-mail originated outside the University of Southampton.

What is the porpouse of adding a method to an existing package from a
cfg.d file? Isnt' better to use a config that points to the function, so
archive can overwrite customizable functions? Like we do already with
eprints/lib/defaultcfg/cfg.d/eprint_validate.pl($c->{validate_eprint} =
sub ...).

Il 01/11/23 14:19, John Salter ha scritto:

the config in z_orcid_support.pl
(https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Feprints%2Forcid_support%2Fblob%2Fmaster%2Fcfg%2Fcfg.d%2Fz_orcid_support.pl%23L124-L130&data=05%7C01%7Ceprints-tech%40ecs.soton.ac.uk%7C2dad4012b1b042fd2f3f08dbdb994d40%7C4a5378f929f44d3ebe89669d03ada9d8%7C0%7C0%7C638345223686918800%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=%2FvEoCL7tKADH6vBFyEBIByVWOE%2FBJAecOrmiLi5UqFQ%3D&reserved=0
) is adding a new method to the EPrints::Script::Compiled package. For
archive ‘aaa’, this is OK. For archive ‘bbb’ (and each one
alphabetically after it), it will be redefining the method – and the
warning is produced.